Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid edit link on game index page #53

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: Invalid edit link on game index page #53

merged 2 commits into from
Sep 26, 2023

Conversation

JoLoZ
Copy link
Member

@JoLoZ JoLoZ commented Sep 26, 2023

No description provided.

@ENDERZOMBI102
Copy link
Member

ENDERZOMBI102 commented Sep 26, 2023 •
edited
Loading

lgtm

~ender

@ozxybox
Copy link
Member

ozxybox commented Sep 26, 2023

Why do we need to replace /ges/ with /pages/?

@JoLoZ
Copy link
Member Author

JoLoZ commented Sep 26, 2023

Becausewe got a fixed slice() which gets us links like https://github.com/StrataSource/Wiki/edit/system-migration/ges/shared/index.md when attempting to edit the index pages of games and simply replacing /ges/ with /pages/ might be less elegant but it's way faster than attempting to figure out which slice value to use.

@ozxybox
Copy link
Member

ozxybox commented Sep 26, 2023

What do we use the fixed slice for?

@ENDERZOMBI102
Copy link
Member

max, are you monkey-patching?

~ender

@JoLoZ
Copy link
Member Author

JoLoZ commented Sep 26, 2023

What do we use the fixed slice for?

To cut off the ../

max, are you monkey-patching?

~ender

monkey noises

@ozxybox
Copy link
Member

ozxybox commented Sep 26, 2023

This code is on the frontend, no? Why does it know about the ../pages/? Can we just trim that data off during generation?

@JoLoZ
Copy link
Member Author

JoLoZ commented Sep 26, 2023

I'll look into it

@JoLoZ JoLoZ marked this pull request as draft September 26, 2023 19:40
@ozxybox
Copy link
Member

ozxybox commented Sep 26, 2023

Thank you!

@JoLoZ JoLoZ marked this pull request as ready for review September 26, 2023 20:02
@JoLoZ JoLoZ requested a review from ozxybox September 26, 2023 20:02
@ozxybox
Copy link
Member

ozxybox commented Sep 26, 2023

Ey, that’s more reasonable. No runtime cost either!

@ozxybox ozxybox merged commit da1e3cc into main Sep 26, 2023
1 check passed
@Gocnak Gocnak deleted the fix/invalid-edit-link-on-index branch September 29, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozxybox ozxybox ozxybox approved these changes

Assignees
No one assigned
Labels
Size 5: Tiny
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoLoZ @ENDERZOMBI102 @ozxybox