Change return type of async from void to Task

StrangeRanger · Feb 27, 2024 · 0a1f7fa · 0a1f7fa
1 parent 923b841
commit 0a1f7fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ActiveDirectoryQuerier.Tests/PowerShellExecutorTests.cs b/ActiveDirectoryQuerier.Tests/PowerShellExecutorTests.cs
@@ -45,7 +45,7 @@ public void Execute_CheckIfOutputChanged_ReturnsDifferentOutput()
     [Theory]
     [InlineData("Get-Command", "Module", "ActiveDirectory")]
     [InlineData("Get-Process", "Name", "explorer")]
-    public async void ExecuteAsync_WhenGivenValidCommand_ReturnsExpectedOutput(string cmd,
+    public async Task ExecuteAsync_WhenGivenValidCommand_ReturnsExpectedOutput(string cmd,
                                                                                string paramName,
                                                                                string paramValue)
     {
@@ -85,7 +85,7 @@ public void Execute_WhenGivenInvalidCommand_ReturnsExpectedOutput(string cmd, st
     [Theory]
     [InlineData("Get-ADUser", "InvalidParameter", "*")]
     [InlineData("InvalidCommand", "Filter", "*")]
-    public async void ExecuteAsync_WhenGivenInvalidCommand_ReturnsExpectedOutput(string cmd,
+    public async Task ExecuteAsync_WhenGivenInvalidCommand_ReturnsExpectedOutput(string cmd,
                                                                                  string paramName,
                                                                                  string paramValue)
     {

diff --git a/ActiveDirectoryQuerier/MainWindowViewModel.cs b/ActiveDirectoryQuerier/MainWindowViewModel.cs
@@ -371,7 +371,7 @@ private async void ExecuteCommandAsync(object _)
     /// <summary>
     /// Initializes the list of Active Directory commands asynchronously.
     /// </summary>
-    private async void InitializeActiveDirectoryCommandsAsync()
+    private async Task InitializeActiveDirectoryCommandsAsync()
     {
         ObservableCollection<Command> list = await ActiveDirectoryCommands.GetActiveDirectoryCommands();
         ActiveDirectoryCommandsList = new(list);
@@ -382,7 +382,7 @@ private async void InitializeActiveDirectoryCommandsAsync()
     /// Loads the parameters for the selected PowerShell command asynchronously.
     /// </summary>
     /// <param name="selectedCommand">The PowerShell command whose parameters are to be loaded.</param>
-    private async void LoadCommandParametersAsync(Command? selectedCommand)
+    private async Task LoadCommandParametersAsync(Command? selectedCommand)
     {
         CommandParameters commandParameters = new();
         await commandParameters.LoadCommandParametersAsync(selectedCommand);