Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update scrolls to auto #159 #160

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Feb 18, 2024

This fix fixes the extra scroll on the search page,

here is the before and after images:

Before on desktop:
image

After desktop
image

Before on Mobile:
image

After mobile:
image

Closes #159.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@oeb25
Copy link
Collaborator

oeb25 commented Feb 18, 2024

This seems entirely reasonable, and thanks for spotting this! Since I primarily develop on macOS where scroll and auto are almost equivalent, stuff like this slips through, so it's great that you went a head and fixed it!

LGTM! 🚀

@oeb25 oeb25 self-requested a review February 18, 2024 10:19
@mikkeldenker mikkeldenker merged commit 20211d8 into StractOrg:main Feb 19, 2024
1 of 2 checks passed
@mikkeldenker
Copy link
Member

Thank you!

@a0m0rajab a0m0rajab deleted the fix-scroll branch February 19, 2024 08:31
@a0m0rajab
Copy link
Contributor Author

You are welcome, I did not know that macOs @oeb25 logic for scroll and auto is the same.
@mikkeldenker it's a great project looking forward to see how it will progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style: the related search showing unnecessary scrolls
4 participants