Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orca2easyspin update #229

Merged
merged 23 commits into from
Feb 24, 2022
Merged

orca2easyspin update #229

merged 23 commits into from
Feb 24, 2022

Conversation

stestoll
Copy link
Member

@stestoll stestoll commented Feb 8, 2022

This PR extends orca2easyspin to be able to read properties for ORCA 3, 4 and 5, either from the main output file or the version-specific property file (binary before 5.0, and text-based 5.0 and later).

Addresses #219 .

  • rework structure of orca2easyspin to allow reading multiple file types (main output, property files)
  • implement spin system import from text-based property file (ORCA 5.0)
  • implement spin system import from main ORCA output file (version independent)
  • add tests particularly for ORCA 5.0
  • push ORCA to fix bugs in property file

@stestoll stestoll added bug Something isn't working enhancement New feature or request labels Feb 8, 2022
@stestoll stestoll added this to the 6.0 milestone Feb 8, 2022
@stestoll stestoll self-assigned this Feb 8, 2022
@stestoll stestoll marked this pull request as ready for review February 24, 2022 20:16
@stestoll
Copy link
Member Author

for list of remaining ORCA v5 property file issues, see #230

@stestoll stestoll linked an issue Feb 24, 2022 that may be closed by this pull request
@stestoll stestoll merged commit e2e45f1 into main Feb 24, 2022
@stestoll stestoll deleted the orca5 branch February 24, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Implement ORCA 5 import
1 participant