Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract common websocket logic #626

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Abstract common websocket logic #626

merged 1 commit into from
Sep 24, 2024

Conversation

StevenWeathers
Copy link
Owner

@StevenWeathers StevenWeathers commented Sep 23, 2024

Description

This PR refactors the common websocket logic used for the poker games, retrospectives, storyboards, and team checkins into an internal package to improve code reuse as well as make it easier to stand up new features.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

This resolves #532

Screenshots/Recordings

Steps to QA

@StevenWeathers StevenWeathers merged commit 9244ab6 into main Sep 24, 2024
9 checks passed
@StevenWeathers StevenWeathers deleted the ws-abstraction branch September 24, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract common websocket logic to shared internal package
1 participant