Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform alignment of strings #126

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Uniform alignment of strings #126

merged 7 commits into from
Nov 19, 2024

Conversation

sebastiaanspeck
Copy link
Contributor

No description provided.

@StevenLooman
Copy link
Owner

Please leave the MagikCheck. These are there on purpose: To show there is no special handling whatsoever for the check. If a parameter is set, then do use the specialization.

@sebastiaanspeck
Copy link
Contributor Author

Please leave the MagikCheck. These are there on purpose: To show there is no special handling whatsoever for the check. If a parameter is set, then do use the specialization.

Will revert that change and only leave the formatting.

@sebastiaanspeck sebastiaanspeck marked this pull request as draft November 18, 2024 03:13
sebastiaanspeck
sebastiaanspeck commented Nov 18, 2024
View reviewed changes
magik-checks/src/test/java/nl/ramsolutions/sw/magik/checks/checks/CommentedCodeCheckTest.java Outdated Show resolved Hide resolved
magik-checks/src/test/java/nl/ramsolutions/sw/magik/checks/checks/CommentedCodeCheckTest.java Outdated Show resolved Hide resolved
magik-checks/src/test/java/nl/ramsolutions/sw/magik/checks/checks/CommentedCodeCheckTest.java Outdated Show resolved Hide resolved
magik-checks/src/test/java/nl/ramsolutions/sw/magik/checks/checks/CommentedCodeCheckTest.java Outdated Show resolved Hide resolved
...cks/src/test/java/nl/ramsolutions/sw/magik/checks/checks/DuplicateMethodInFileCheckTest.java Outdated Show resolved Hide resolved
...ava/nl/ramsolutions/sw/magik/typedchecks/checks/UndefinedMethodCallResultTypedCheckTest.java Outdated Show resolved Hide resolved
...ava/nl/ramsolutions/sw/magik/typedchecks/checks/UndefinedMethodCallResultTypedCheckTest.java Outdated Show resolved Hide resolved
...ava/nl/ramsolutions/sw/magik/typedchecks/checks/UndefinedMethodCallResultTypedCheckTest.java Outdated Show resolved Hide resolved
...ava/nl/ramsolutions/sw/magik/typedchecks/checks/UndefinedMethodCallResultTypedCheckTest.java Outdated Show resolved Hide resolved
...ava/nl/ramsolutions/sw/magik/typedchecks/checks/UndefinedMethodCallResultTypedCheckTest.java Outdated Show resolved Hide resolved
@sebastiaanspeck sebastiaanspeck changed the title Use correct (Type)Check-class and uniform alignment of strings Uniform alignment of strings Nov 18, 2024
@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review November 18, 2024 05:34
@StevenLooman StevenLooman merged commit 169afa3 into StevenLooman:develop Nov 19, 2024
4 checks passed
@StevenLooman
Copy link
Owner

Thanks!

@sebastiaanspeck sebastiaanspeck deleted the formatting-tests branch November 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastiaanspeck @StevenLooman