Apply suggestions from code review

StevenLooman · Nov 18, 2024 · 575fdbd · 575fdbd
1 parent 4b864c0
commit 575fdbd
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 18 deletions.
diff --git a/.../ramsolutions/sw/magik/typedchecks/checks/ConditionalExpressionIsFalseTypedCheckTest.java b/.../ramsolutions/sw/magik/typedchecks/checks/ConditionalExpressionIsFalseTypedCheckTest.java
@@ -33,8 +33,7 @@ class ConditionalExpressionIsFalseTypedCheckTest extends MagikTypedCheckTestBase
       })
   void testOk(final String code) {
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
-    final ConditionalExpressionIsFalseTypedCheck check =
-        new ConditionalExpressionIsFalseTypedCheck();
+    final MagikTypedCheck check = new ConditionalExpressionIsFalseTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).isEmpty();
   }
@@ -55,8 +54,7 @@ void testOk(final String code) {
       })
   void testFail(final String code) {
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
-    final ConditionalExpressionIsFalseTypedCheck check =
-        new ConditionalExpressionIsFalseTypedCheck();
+    final MagikTypedCheck check = new ConditionalExpressionIsFalseTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).hasSize(1);
   }

diff --git a/...s/sw/magik/typedchecks/checks/MethodArgumentCountMatchesParameterCountTypedCheckTest.java b/...s/sw/magik/typedchecks/checks/MethodArgumentCountMatchesParameterCountTypedCheckTest.java
@@ -25,8 +25,7 @@ void testMethodUnknown() {
           object.m()
         _endblock""";
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
-    final MethodArgumentCountMatchesParameterCountTypedCheck check =
-        new MethodArgumentCountMatchesParameterCountTypedCheck();
+    final MagikTypedCheck check = new MethodArgumentCountMatchesParameterCountTypedCheck();
     final List<MagikIssue> issues = this.runCheck(code, definitionKeeper, check);
     assertThat(issues).isEmpty();
   }
@@ -73,8 +72,7 @@ void testArgumentCountMatches() {
         _block
           object.m(object, object)
         _endblock""";
-    final MethodArgumentCountMatchesParameterCountTypedCheck check =
-        new MethodArgumentCountMatchesParameterCountTypedCheck();
+    final MagikTypedCheck check = new MethodArgumentCountMatchesParameterCountTypedCheck();
     final List<MagikIssue> issues = this.runCheck(code, definitionKeeper, check);
     assertThat(issues).isEmpty();
   }
@@ -121,8 +119,7 @@ void testArgumentMissing() {
         _block
           object.m(object)
         _endblock""";
-    final MethodArgumentCountMatchesParameterCountTypedCheck check =
-        new MethodArgumentCountMatchesParameterCountTypedCheck();
+    final MagikTypedCheck check = new MethodArgumentCountMatchesParameterCountTypedCheck();
     final List<MagikIssue> issues = this.runCheck(code, definitionKeeper, check);
     assertThat(issues).hasSize(1);
   }

diff --git a/...ons/sw/magik/typedchecks/checks/MethodArgumentTypeMatchesParameterTypeTypedCheckTest.java b/...ons/sw/magik/typedchecks/checks/MethodArgumentTypeMatchesParameterTypeTypedCheckTest.java
@@ -81,8 +81,7 @@ void testArgumentTypeMatches(final String code) {
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
     this.addTestMethods(definitionKeeper);
 
-    final MethodArgumentTypeMatchesParameterTypeTypedCheck check =
-        new MethodArgumentTypeMatchesParameterTypeTypedCheck();
+    final MagikTypedCheck check = new MethodArgumentTypeMatchesParameterTypeTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).isEmpty();
   }
@@ -97,8 +96,7 @@ void testArgumentTypeNotMatches(final String code) {
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
     this.addTestMethods(definitionKeeper);
 
-    final MethodArgumentTypeMatchesParameterTypeTypedCheck check =
-        new MethodArgumentTypeMatchesParameterTypeTypedCheck();
+    final MagikTypedCheck check = new MethodArgumentTypeMatchesParameterTypeTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).hasSize(1);
   }

diff --git a/...solutions/sw/magik/typedchecks/checks/SwChar16VectorEvaluateInvocationTypedCheckTest.java b/...solutions/sw/magik/typedchecks/checks/SwChar16VectorEvaluateInvocationTypedCheckTest.java
@@ -14,8 +14,7 @@ class SwChar16VectorEvaluateInvocationTypedCheckTest extends MagikTypedCheckTest
   void testUseOfSwChar16VectorEvaluate() {
     final String code = "'abc'.evaluate()";
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
-    final SwChar16VectorEvaluateInvocationTypedCheck check =
-        new SwChar16VectorEvaluateInvocationTypedCheck();
+    final MagikTypedCheck check = new SwChar16VectorEvaluateInvocationTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).hasSize(1);
   }
@@ -24,8 +23,7 @@ void testUseOfSwChar16VectorEvaluate() {
   void testUseOfOtherEvaluate() {
     final String code = "100.evaluate()";
     final IDefinitionKeeper definitionKeeper = new DefinitionKeeper();
-    final SwChar16VectorEvaluateInvocationTypedCheck check =
-        new SwChar16VectorEvaluateInvocationTypedCheck();
+    final MagikTypedCheck check = new SwChar16VectorEvaluateInvocationTypedCheck();
     final List<MagikIssue> checkResults = this.runCheck(code, definitionKeeper, check);
     assertThat(checkResults).isEmpty();
   }