Drop templated check support, including checks CommentRegularExpressi…

…onCheck and XPathCheck

CHANGES.md

@@ -26,6 +26,7 @@
 - Move functionality from implementation provider to definition provider in magik-language-server.
 - Implementation provider now provides impementations of abstract methods.
 - Add SelectionRangeProvider to magik-language-server.
+- Drop templated check support, including checks CommentRegularExpressionCheck and XPathCheck.
 - Various small fixes.
 
 0.7.1 (2023-02-21)

magik-checks/pom.xml

@@ -22,10 +22,6 @@
       <groupId>org.sonarsource.sonarqube</groupId>
       <artifactId>sonar-check-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.sonarsource.sslr</groupId>
-      <artifactId>sslr-xpath</artifactId>
-    </dependency>
 
     <dependency>
       <groupId>org.json</groupId>

magik-checks/src/main/java/nl/ramsolutions/sw/magik/checks/CheckList.java

@@ -3,7 +3,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
-import nl.ramsolutions.sw.magik.checks.checks.CommentRegularExpressionCheck;
 import nl.ramsolutions.sw.magik.checks.checks.CommentedCodeCheck;
 import nl.ramsolutions.sw.magik.checks.checks.DuplicateMethodInFileCheck;
 import nl.ramsolutions.sw.magik.checks.checks.EmptyBlockCheck;
@@ -38,7 +37,6 @@
 import nl.ramsolutions.sw.magik.checks.checks.VariableDeclarationUsageDistanceCheck;
 import nl.ramsolutions.sw.magik.checks.checks.VariableNamingCheck;
 import nl.ramsolutions.sw.magik.checks.checks.WarnedCallCheck;
-import nl.ramsolutions.sw.magik.checks.checks.XPathCheck;
 
 /**
  * Check list.
@@ -63,7 +61,6 @@ private CheckList() {
      */
     public static List<Class<?>> getChecks() {
         return List.of(
-            CommentRegularExpressionCheck.class,
             CommentedCodeCheck.class,
             DuplicateMethodInFileCheck.class,
             EmptyBlockCheck.class,
@@ -97,8 +94,7 @@ public static List<Class<?>> getChecks() {
             VariableCountCheck.class,
             VariableDeclarationUsageDistanceCheck.class,
             VariableNamingCheck.class,
-            WarnedCallCheck.class,
-            XPathCheck.class);
+            WarnedCallCheck.class);
     }
 
     /**
@@ -119,14 +115,4 @@ public static List<Class<?>> getDisabledByDefaultChecks() {
             .collect(Collectors.toList());
     }
 
-    /**
-     * Get {@link MagikCheck}s which are templated.
-     * @return List of {@link MagikCheck}s.
-     */
-    public static List<Class<?>> getTemplatedChecks() {
-        return getChecks().stream()
-            .filter(checkClass -> checkClass.getAnnotation(TemplatedMagikCheck.class) != null)
-            .collect(Collectors.toList());
-    }
-
 }

magik-language-server/src/main/java/nl/ramsolutions/sw/magik/languageserver/implementation/ImplementationProvider.java

@@ -17,16 +17,12 @@
 import nl.ramsolutions.sw.magik.analysis.typing.types.UndefinedType;
 import nl.ramsolutions.sw.magik.api.MagikGrammar;
 import org.eclipse.lsp4j.ServerCapabilities;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Implementation provider.
  */
 public class ImplementationProvider {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(ImplementationProvider.class);
-
     /**
      * Set server capabilities.
      * @param capabilities Server capabilities.