Revert points back to non Vogen type for now. Fix bug where speeds we…

…re wrong (should've been 1f instead of .100f)

src/PacMan.GameComponents/LevelStats.cs

@@ -91,15 +91,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Apple,
             FruitPoints: Points.From(700),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 40,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 20,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.TwoSeconds,
@@ -108,15 +108,15 @@ public class LevelStats
             CutScene: IntroCutScene.GhostSnagged,
             Fruit1: FruitItem.Apple,
             FruitPoints: Points.From(700),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 50,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 25,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.TwoSeconds,
@@ -125,15 +125,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Grape,
             FruitPoints: Points.From(1000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 50,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 25,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.TwoSeconds,
@@ -142,15 +142,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Grape,
             FruitPoints: Points.From(1000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 50,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 25,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.OneSecond,
@@ -159,15 +159,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Galaxian,
             FruitPoints: Points.From(2000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 60,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 30,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.FiveSeconds,
@@ -176,15 +176,15 @@ public class LevelStats
             CutScene: IntroCutScene.TornGhostAndWorm,
             Fruit1: FruitItem.Galaxian,
             FruitPoints: Points.From(2000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 60,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 30,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.TwoSeconds,
@@ -193,15 +193,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Bell,
             FruitPoints: Points.From(3000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 60,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 30,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.OneSecond,
@@ -210,15 +210,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Bell,
             FruitPoints: Points.From(3000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 80,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 40,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime: GhostFrightDuration.OneSecond,
@@ -227,15 +227,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 80,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 40,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime:  GhostFrightDuration.OneSecond,
@@ -244,15 +244,15 @@ public class LevelStats
             CutScene: IntroCutScene.TornGhostAndWorm,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 80,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 40,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime:  GhostFrightDuration.ThreeSeconds,
@@ -261,15 +261,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 100,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 50,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime:  GhostFrightDuration.OneSecond,
@@ -278,15 +278,15 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 100,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 50,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime:  GhostFrightDuration.OneSecond,
@@ -295,14 +295,14 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 100,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 50,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
             FrightPacManSpeedPc:  SpeedPercentage.From(.0f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.0f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.0f),
@@ -312,15 +312,15 @@ public class LevelStats
             CutScene: IntroCutScene.TornGhostAndWorm,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 100,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 50,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
-            FrightPacManSpeedPc:  SpeedPercentage.From(.100f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
+            FrightPacManSpeedPc:  SpeedPercentage.From(1f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.87f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.60f),
             FrightGhostTime:  GhostFrightDuration.OneSecond,
@@ -329,14 +329,14 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 120,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 60,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
             FrightPacManSpeedPc:  SpeedPercentage.From(.0f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.0f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.0f),
@@ -346,14 +346,14 @@ public class LevelStats
             CutScene: IntroCutScene.None,
             Fruit1: FruitItem.Key,
             FruitPoints: Points.From(5000),
-            PacManSpeedPc:  SpeedPercentage.From(.100f),
+            PacManSpeedPc:  SpeedPercentage.From(1f),
             PacManDotsSpeedPc:  SpeedPercentage.From(.87f),
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 120,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 60,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
             FrightPacManSpeedPc:  SpeedPercentage.From(.0f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.0f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.0f),
@@ -368,9 +368,9 @@ public class LevelStats
             GhostSpeedPc:  SpeedPercentage.From(.95f),
             GhostTunnelSpeedPc:  SpeedPercentage.From(.50f),
             Elroy1DotsLeft: 120,
-            Elroy1SpeedPc:  SpeedPercentage.From(.100f),
+            Elroy1SpeedPc:  SpeedPercentage.From(1f),
             Elroy2DotsLeft: 60,
-            Elroy2SpeedPc:  SpeedPercentage.From(.105f),
+            Elroy2SpeedPc:  SpeedPercentage.From(1.05f),
             FrightPacManSpeedPc:  SpeedPercentage.From(.0f),
             FrightPacManDotSpeedPc:  SpeedPercentage.From(.0f),
             FrightGhostSpeedPc:  SpeedPercentage.From(.0f),

src/PacMan.GameComponents/PlayerStats.cs

@@ -14,7 +14,7 @@ public class PlayerStats
 
     private GhostMovementConductor _ghostMovementConductor;
 
-    private readonly List<Score> _extraLives;
+    private readonly List<int> _extraLives;
 
     [SuppressMessage("ReSharper", "HeapView.ObjectAllocation.Evident")]
     public PlayerStats(int playerIndex, IMediator mediator)
@@ -28,7 +28,7 @@ public PlayerStats(int playerIndex, IMediator mediator)
         Lives = Constants.PacManLives;
         _levelNumber = -1;
 
-        _extraLives = [Score.From(10_000)];
+        _extraLives = [10_000];
         _levelStats = new(0);
         _ghostHouseDoor = new(0, _mediator);
 
@@ -82,7 +82,7 @@ public void NewLevel()
 
     protected virtual async ValueTask IncreaseScoreBy(Points points)
     {
-        Score = Score.IncreaseBy(points);
+        Score.IncreaseBy(points);
 
         if (_extraLives.Count == 0)
         {

src/PacMan.GameComponents/Primitives/Score.cs

@@ -1,12 +1,10 @@
-using Vogen;
+namespace PacMan.GameComponents.Primitives;
 
-namespace PacMan.GameComponents.Primitives;
-
-[ValueObject<int>(toPrimitiveCasting: CastOperator.Implicit)]
-public partial struct Score
+public record struct Score(int Value)
 {
-    [Pure]
-    public Score IncreaseBy(Points points) => From(Value + points.Value);
+    public void IncreaseBy(Points points) => Value += points.Value;
 
     public static readonly Score Zero = new(0);
+
+    public static implicit operator int(Score score) => score.Value;
 }

test/SmallTests/ScoreTests.cs

@@ -33,21 +33,21 @@ public void Defaulting()
         public void Increase()
         {
             var s = Score.Zero;
-            s = s.IncreaseBy(Points.From(10));
+            s.IncreaseBy(Points.From(10));
 
             s.Value.Should().Be(10);
 
             Score.Zero.Value.Should().Be(0);
 
-            s = s.IncreaseBy(Points.From(10));
+            s.IncreaseBy(Points.From(10));
             s.Value.Should().Be(20);
         }
 
         [Fact]
         public void Implicit_int()
         {
             var s = Score.Zero;
-            s = s.IncreaseBy(Points.From(10));
+            s.IncreaseBy(Points.From(10));
 
             int val = s;
             val.Should().Be(10);