Gymnasium migration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stupid question but why is |
|
No such thing as a stupid question! You are correct. The "truncated" implementation is incomplete and should indeed be based on exceeding the max steps. I'll fix it shortly. Please be aware that future development of NLE is moving to https://github.com/heiner/nle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of facebookresearch#373
These are a bunch of (probably breaking) changes to align with the Gymnasium 0.29.1 API, following the ending of OpenAI Gym support.
This addresses the following issues:
facebookresearch#357
facebookresearch#327
facebookresearch#326
Supersedes facebookresearch#371
Tests are passing on Python 3.8 to Python 3.11 with the new API.