Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements with didactic value #22

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Some improvements with didactic value #22

wants to merge 36 commits into from

Commits on Feb 19, 2018

  1. differentiated the state name from the prop mapped name to understand… 

    … more
    @pimoGit
    pimoGit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    8dd90f8 View commit details
    Browse the repository at this point in the history

  2. fix errs in the comments

    @pimoGit
    pimoGit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    19a2fa5 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. added some clarification comments

    @pimoGit
    pimoGit committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    b295378 View commit details
    Browse the repository at this point in the history

  2. change some comments for better

    @pimoGit
    pimoGit committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    528aafe View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. added some useful comments

    @pimoGit
    pimoGit committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    47d0b53 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. comments added for custom HOC and delted gmap ref da index

    @pimoGit
    pimoGit committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    705b25d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. more comments

    @pimoGit
    pimoGit committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    35800e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. added key to list item and useful comments, get rid og gmap ref, chan… 

    …ge a callback funct on map to clearify
    @pimoGit
    pimoGit committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    02f8c68 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. enanched some comments

    @pimoGit
    pimoGit committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    829c127 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. corrected some commnts

    @pimoGit
    pimoGit committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    5d60960 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. added some useful commets

    @pimoGit
    pimoGit committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    b39af64 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. added useful comments

    @pimoGit
    pimoGit committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    5c22444 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. more comments

    @pimoGit
    pimoGit committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    4414bf3 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. some useful comments added

    @pimoGit
    pimoGit committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    a135b5c View commit details
    Browse the repository at this point in the history

  2. again comments

    @pimoGit
    pimoGit committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    1064d93 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2018

  1. more comments

    @pimoGit
    pimoGit committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    d832025 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. get rid of gmap and added useful comment

    @pimoGit
    pimoGit committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    afc22f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. useful comments again

    @pimoGit
    pimoGit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    e8a4207 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. my compressed vers of validate, draft of comp optimization, comments

    @pimoGit
    pimoGit committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    7114032 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. cleaned up the working signup and added an alt V draft file

    @pimoGit
    pimoGit committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    70b3cc5 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2018

  1. refactoring draft potential actions optimization + comments

    @pimoGit
    pimoGit committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    3b77b6e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. alt V to include HOC-auth directly in the feature comp, and commented… 

    … out + other useful comment
    @pimoGit
    pimoGit committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    acc5d4c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. resolved srevr err alert duplication V2 - simpler way

    @pimoGit
    pimoGit committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    8b9573d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. clear commented action optimization vto create a new branch for it

    @pimoGit
    pimoGit committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    c4536c7 View commit details
    Browse the repository at this point in the history

  2. uncomment the refactoring action

    @pimoGit
    pimoGit committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    dc97f58 View commit details
    Browse the repository at this point in the history

  3. action optimization, eliminated repeated code and centralized it in a… 

    … external function
    @pimoGit
    pimoGit committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    6b9c329 View commit details
    Browse the repository at this point in the history

  4. resolved merge conflit for: action optimization, eliminated repeated … 

    …code and centralized it in a external function
    @pimoGit
    pimoGit committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    077731d View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. join the 2 files in this version

    @pimoGit
    pimoGit committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    28c5f91 View commit details
    Browse the repository at this point in the history

  2. deleted useles file after branching

    @pimoGit
    pimoGit committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b0509d8 View commit details
    Browse the repository at this point in the history

  3. deleted useless file on the new branch

    @pimoGit
    pimoGit committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    d99b5d3 View commit details
    Browse the repository at this point in the history

  4. first attemtp to work of this version

    @pimoGit
    pimoGit committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    ec1e19b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. some fixing and one step forward to make work this version

    @pimoGit
    pimoGit committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    590cd81 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. trying to debug this version

    @pimoGit
    pimoGit committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    f8cadea View commit details
    Browse the repository at this point in the history

  2. made this version of optimized signup comp work

    @pimoGit
    pimoGit committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    52713de View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. output labels and err msg in a better way

    @pimoGit
    pimoGit committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    7d1e60a View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Merge branch 'signup-comp-v2'

    @pimoGit
    pimoGit committed May 4, 2018
    Configuration menu
    Copy the full SHA
    565a41b View commit details
    Browse the repository at this point in the history