Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend overhaul #195

Merged
merged 16 commits into from
Jan 5, 2025
Merged

Backend overhaul #195

merged 16 commits into from
Jan 5, 2025

Conversation

StephanAkkerman
Copy link
Owner

Description

This PR refactors the backend. By trying to follow the suggested structure in issue #187
I was not able to remove the setup.py dependency for now and usage of the backend needs to still happen with pip install .

@TimKoornstra please let me know your thoughts on this

Related Tickets & Documents

Fixes #187

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added to documentation?

  • 📜 README.md
  • 📓 Wiki
  • 🙅 No documentation needed

@StephanAkkerman StephanAkkerman marked this pull request as ready for review January 4, 2025 11:16
backend/fluentai/services/imagine/image_gen.py Outdated Show resolved Hide resolved
backend/fluentai/services/imagine/verbal_cue.py Outdated Show resolved Hide resolved
backend/fluentai/services/imagine/verbal_cue.py Outdated Show resolved Hide resolved
backend/fluentai/constants/languages.py Outdated Show resolved Hide resolved
backend/fluentai/api/api.py Outdated Show resolved Hide resolved
backend/fluentai/services/mnemonic/phonetic/g2p.py Outdated Show resolved Hide resolved
backend/fluentai/services/mnemonic/phonetic/phonetic.py Outdated Show resolved Hide resolved
backend/fluentai/services/mnemonic/phonetic/utils/utils.py Outdated Show resolved Hide resolved
backend/fluentai/services/mnemonic/semantic/semantic.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@TimKoornstra TimKoornstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing wrong is the imageability_models imports. I don't think they resolve correctly

@StephanAkkerman
Copy link
Owner Author

Also created a class for run.py

Copy link
Collaborator

@TimKoornstra TimKoornstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StephanAkkerman StephanAkkerman merged commit c870bc1 into main Jan 5, 2025
6 checks passed
@StephanAkkerman StephanAkkerman deleted the feat/backend-overhaul branch January 5, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor back-end code
2 participants