fix: output corruption when control sequence left in buffer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepY1aoZz
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed issues c-bata#119, openGemini/openGemini#519 and c-bata#223.
When users input too fast (a common case is scrolling mouse in tmux), more than one key code was read from STDIN. If there is any control key (i.e. UP,DOWN,DELETE) in it, they will be regarded as normal characters, and further output to the terminal. Also, the method calculating the length of current line returns a wrong value, which caused a part of current output cannot be erased.
This PR removed all control sequences in input before they were stored into buffer or output to the terminal.
Example
BEFORE
AFTER