Corrects missing images #25
Conversation
(Fixed) Some paths have \r at the end of the path on Windows 10 environment. (Fixed) Some image paths not being found. Step7750#21
| @@ -795,6 +806,10 @@ class CSGOCdn extends EventEmitter { | |||
| } | |||
| else { | |||
| // Other in items | |||
| if( marketHashName.indexOf('(Holo-Foil)') > -1 ) { | |||
There was a problem hiding this comment.
AFAIK, there was an issue earlier where these were misspellings my Valve. They don't have proper market pages, right? Seems hacky to do this conversion if Valve isn't bothered to do it.
There was a problem hiding this comment.
Yes, it is a hacky way to do it and not looking the right way. But people who are using this package want to see the correct results. Perhaps we can make hooks or interceptors where users can add their own hacky codes. What do you think about it?
| const path = this.vpkFiles.find((t) => t.endsWith(fileName)); | ||
|
|
||
| if (path) return this.getPathURL(path); | ||
| if (path) return this.getPathURL(path).replace('\r', ''); |
There was a problem hiding this comment.
Is eliminating the carriage return absolutely necessary? If it is, then it should be universally stripped during the parsing of the game files instead of scattered everywhere.
There was a problem hiding this comment.
I think it's necessary. Because URLs become https://steamcommunity.com/.../abcd.png\r or something like that.
You are right. I will change the replacer positions 👍
(Fixed) Some paths have \r at the end of the path on Windows 10 environment.
(Fixed) Some image paths not being found. #21