Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use xdrlib3 instead of xdrlib. #739

Merged
merged 2 commits into from
Jul 17, 2023
Merged

deps: use xdrlib3 instead of xdrlib. #739

merged 2 commits into from
Jul 17, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Jun 16, 2023

xdrlib will be removed in Python 3.13.

#646

`xdrlib` will be removed in Python 3.13.
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #739 (978cca0) into main (4286734) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files         233      233           
  Lines       11334    11334           
=======================================
+ Hits        11249    11250    +1     
+ Misses         85       84    -1     
Flag Coverage Δ
unittests 99.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stellar_sdk/fee_bump_transaction_envelope.py 95.45% <100.00%> (ø)
stellar_sdk/strkey.py 99.37% <100.00%> (ø)
stellar_sdk/transaction_envelope.py 97.26% <100.00%> (ø)

... and 1 file with indirect coverage changes

# Conflicts:
#	poetry.lock
@overcat overcat changed the title refactor: use xdrlib3 instead of xdrlib. deps: use xdrlib3 instead of xdrlib. Jul 17, 2023
@overcat overcat merged commit 42ad26b into main Jul 17, 2023
@overcat overcat deleted the use-xdrlib3 branch July 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant