Make configuration easier by including user_config.h #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to customize configuration values (for example PWM_MAX_CHANNELS) without modifying pwm.c or including pwm.c from another .c file.
Makes it easier to customize them.
The "Non-OS" SDK only defines ICACHE_FLASH_ATTR and locates functions without specific annotations in RAM by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By including
user_config.hat the top of the file, it's possible to make configuration changes while using the unmodified code from the repository.To make that also possible for both PWM_DEBUG and PWM_USE_NMI, include them in ifndef like already done for SDK_PWM_PERIOD_COMPAT_MODE and PWM_MAX_CHANNELS.