Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Chromium headless browser instead of PhantomJS #46

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

@StefanBratanov StefanBratanov changed the title Move to Chromium headless browser instead of PhantomJS Move to Firefox headless browser instead of PhantomJS Dec 3, 2023
@StefanBratanov StefanBratanov changed the title Move to Firefox headless browser instead of PhantomJS Move to Chromium headless browser instead of PhantomJS Dec 4, 2023
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cd37b16) 78.87% compared to head (78a11fd) 78.94%.

Files Patch % Lines
...arketsapi/brochure/FantasticoBrochureDownloader.kt 85.71% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     78.87%   78.94%   +0.06%     
  Complexity      240      240              
============================================
  Files            47       47              
  Lines          1354     1363       +9     
  Branches        218      219       +1     
============================================
+ Hits           1068     1076       +8     
  Misses          153      153              
- Partials        133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StefanBratanov StefanBratanov merged commit b6cbe3d into master Dec 4, 2023
3 checks passed
@StefanBratanov StefanBratanov deleted the remove_phantom_js branch December 4, 2023 10:55
StefanBratanov added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants