Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/13 code clean #14

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Feature/13 code clean #14

wants to merge 15 commits into from

Conversation

Swiftwork
Copy link

@Swiftwork Swiftwork commented Aug 16, 2020 •
edited
Loading

Pull request connected to issue #13 tracking changes

Linting

  • Improve code formatting with uniform spacing and lines
  • Remove obsolete code disabled by comments

Documentation

  • Correct spelling and grammar of code comments
  • Translate remaining code comments to English
  • Improve documentation regarding installation, setting secrets, and building
  • Code examples in separate directory

Refactoring

  • Refactor build params system removing "YES_" and "NOT_", replacing with documentation
  • Folder structure to make maintenance and code responsibility clearer

@Swiftwork Swiftwork marked this pull request as ready for review September 30, 2020 18:09
@Swiftwork
Copy link
Author

@Stef-aap a large amount of refactoring has been made, but only a few things differ from the original code. I would suggest fetching the fork and looking through the project structure rather than trying to look at GitHub diffs, as these are quite hard to follow. Feel free to request changes :)

@Swiftwork
Copy link
Author

Following PR closes #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Swiftwork