Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ping health contributor #1443

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add ping health contributor #1443

wants to merge 1 commit into from

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jan 16, 2025

Description

Adds a ping contributor

Resolves #1439

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jan 16, 2025
@TimHess TimHess self-assigned this Jan 16, 2025
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from sealing internal type.


namespace Steeltoe.Management.Endpoint.Actuators.Health.Contributors;

internal class PingContributorOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
internal class PingContributorOptions
internal sealed class PingContributorOptions

@bart-vmware
Copy link
Member

The documentation at https://github.com/SteeltoeOSS/Documentation/blob/v4/api/v4/management/health.md needs to be adapted for this and earlier changes.

  • Default of ShowDetails
    image
  • Include the ping contributor in the list of contributors that are enabled by default
    image
  • Include the ping actuator in the sample output
    image

Please check off the following entry in the PR description, providing a link to a documentation PR.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ping health contributor
2 participants