Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-merge fixes #324

Merged
merged 3 commits into from
May 28, 2024
Merged

Post-merge fixes #324

merged 3 commits into from
May 28, 2024

Conversation

bart-vmware
Copy link
Member

Fixes merge errors from #323 and removes components deleted in Steeltoe v4.

@bart-vmware bart-vmware changed the base branch from main to v4 May 23, 2024 07:24
@bart-vmware bart-vmware marked this pull request as ready for review May 23, 2024 07:24
@bart-vmware bart-vmware requested a review from TimHess May 23, 2024 07:24
@bart-vmware
Copy link
Member Author

@TimHess Can you take a look at the failing build? It's all working locally (including MainSite and API browser).

Copy link

Preview link: https://docs-steeltoe-pr-324.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

@bart-vmware
Copy link
Member Author

bart-vmware commented May 27, 2024

@TimHess Thanks! Looks good now. Can you approve this PR?

@bart-vmware bart-vmware merged commit d6abd05 into v4 May 28, 2024
5 checks passed
@bart-vmware bart-vmware deleted the post-merge-fixes branch May 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants