Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Service Discovery #322

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented May 21, 2024

Updates the documentation for Steeltoe Service Discovery to match with the latest bits in Steeltoe:main (v4).
Removes TOC numbering, because styling broke when using deeper nesting than before.

@bart-vmware bart-vmware marked this pull request as ready for review May 21, 2024 15:03
@bart-vmware bart-vmware requested a review from TimHess May 21, 2024 15:03
@bart-vmware
Copy link
Member Author

@TimHess Can we have something similar to SteeltoeOSS/MainSite#145 (comment) on this repo? I'd like to see the effects of my CSS changes on mobile devices.

@TimHess
Copy link
Member

TimHess commented May 22, 2024

@TimHess Can we have something similar to SteeltoeOSS/MainSite#145 (comment) on this repo? I'd like to see the effects of my CSS changes on mobile devices.

That is already setup on PR to main in this repo... #323 should bring everything that has changed in main to v4 including the pipeline changes and a new update to also run build & stage during PR to v4. However, I am not entirely sure if the change to the branch filter will work if the pipeline file in the v4 branch is updated or if we'll also need to push that change in main

api/v4/discovery/initialize-discovery-client.md Outdated Show resolved Hide resolved
api/v4/discovery/initialize-discovery-client.md Outdated Show resolved Hide resolved
api/v4/discovery/index.md Outdated Show resolved Hide resolved
api/v4/discovery/discovering-services.md Outdated Show resolved Hide resolved
@bart-vmware bart-vmware requested a review from TimHess May 23, 2024 07:44
@bart-vmware bart-vmware merged commit 9b7f19c into v4 May 23, 2024
1 check passed
@bart-vmware bart-vmware deleted the update-discovery-docs branch May 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants