Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: remove docker, add chocolatey. Update framework targets #315

Merged
merged 16 commits into from
Mar 1, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Feb 22, 2024

While this won't fix the story of a local docker build all the way through, it should~ clarify how to get a complete local build #263

Convert to a single workflow, add new ARGS in dockerfiles to allow selecting a different base image at build time
Resolves #316

Preferring not to document the docker workflow in the readme at this time given issues with hosting docfx from within docker.. anybody who really wants to do what the CI workflow does can follow what is in the workflow file

@TimHess TimHess self-assigned this Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

Preview link: https://docs-steeltoe-pr-315.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the instructions to build the API browser doesn't work. Same for MainSite integration.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
api-filter.yml Outdated Show resolved Hide resolved
api/v3/welcome/common-steps.md Outdated Show resolved Hide resolved
api/v3/welcome/common-steps.md Outdated Show resolved Hide resolved
.github/workflows/build-APIdocs-layer.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing updates to docfx version.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bart-vmware
bart-vmware previously approved these changes Feb 27, 2024
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this worked out pretty nicely!

.github/workflows/build-and-stage.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-stage.yml Show resolved Hide resolved
.github/workflows/build-and-stage.yml Show resolved Hide resolved
.github/workflows/build-and-stage.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@bart-vmware bart-vmware mentioned this pull request Mar 1, 2024
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

.github/workflows/build-and-stage.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-stage.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-stage.yml Show resolved Hide resolved
@TimHess TimHess requested a review from bart-vmware March 1, 2024 14:51
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this doesn't fix #319. Let's merge this and leave that issue open.

@TimHess TimHess merged commit a117b4f into main Mar 1, 2024
5 checks passed
@TimHess TimHess deleted the local_metadata branch March 1, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GitHub Actions Structure
2 participants