-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: remove docker, add chocolatey. Update framework targets #315
Conversation
Preview link: https://docs-steeltoe-pr-315.azurewebsites.net
|
ffbc503
to
b7c4727
Compare
b7c4727
to
9de1e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the instructions to build the API browser doesn't work. Same for MainSite integration.
Co-authored-by: Bart Koelman <[email protected]>
…ncy ids for gha workflows
7ee9bf0
to
2073e90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing updates to docfx version.
Co-authored-by: Bart Koelman <[email protected]>
… image stack in a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this worked out pretty nicely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, this doesn't fix #319. Let's merge this and leave that issue open.
While this won't fix the story of a local docker build all the way through, itshould~ clarify how to get a complete local build #263Convert to a single workflow, add new ARGS in dockerfiles to allow selecting a different base image at build time
Resolves #316
Preferring not to document the docker workflow in the readme at this time given issues with hosting docfx from within docker.. anybody who really wants to do what the CI workflow does can follow what is in the workflow file