Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KSP 1.10 comets in Custom Asteroids #47

Closed
5 tasks done
Starstrider42 opened this issue Jul 5, 2020 · 2 comments
Closed
5 tasks done

Support KSP 1.10 comets in Custom Asteroids #47

Starstrider42 opened this issue Jul 5, 2020 · 2 comments

Comments

@Starstrider42
Copy link
Owner

Starstrider42 commented Jul 5, 2020

KSP 1.10 adds comets to the stock game. Custom Asteroids should be able to generate such comets itself, replacing the asteroids-on-cometary-orbits approach of previous versions.

Specific requirements:

  • Custom Asteroids must still be able to work with asteroid packs written for previous versions of KSP or Custom Asteroids.
  • The comets provided by the "standard" config packs must emulate stock comets. This means changing the properties of the existing oort and innerComets groups (which roughly correspond to long- and intermediate-period comets in the new system).
  • Comet-related contracts must be able to recognize new comets created by Custom Asteroids, whether or not they're from a group that emulates stock comets.
  • I'm not sure yet how much interaction the new code should have with the stock COMET_ORBIT_TYPE configs.
    • ModuleComet and CometVessel almost certainly depend on these blocks, so they must be used at least for comets' physical properties.
    • Custom Asteroids provides more flexible orbit specification than the stock configs.
    • On the other hand, Custom Asteroids does not (yet) support custom sampling experiments for asteroids of the same part type. Having each type of object be its own part is clunkier than the stock approach, but more powerful (since it naturally handles resources, textures, etc. as well).
  • Sentinel support for comets need not be handled yet (see Sentinel Telescope creates non-CA asteroids #35).
  • It would be helpful if the Custom Asteroids code and configs could gracefully revert to the old behavior for KSP 1.9 and earlier, but this would require Custom Asteroids to create a substitute PotatoComet that would not be a drop-in replacement for the real thing (different modules). This seems like more trouble than it's worth.
@Starstrider42
Copy link
Owner Author

Starstrider42 commented Jul 5, 2020

@DMagic1, this issue may interest you, since IIRC some of your asteroid experiments assumed the existence of CaCometActive.

@Starstrider42
Copy link
Owner Author

Starstrider42 commented Aug 2, 2020

Backward compatibility with KSP 1.9 is impractical; even just recompiling the current mod against KSP 1.10 gives lots of exceptions when running on KSP 1.9. This does not prevent compatibility with old configs, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant