Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KSP 1.10 comets in "extras" configs #2

Closed
Starstrider42 opened this issue Jul 5, 2020 · 4 comments
Closed

Support KSP 1.10 comets in "extras" configs #2

Starstrider42 opened this issue Jul 5, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@Starstrider42
Copy link
Owner

Once Starstrider42/Custom-Asteroids#47 is implemented, create versions of the configs that use stock comets. Depending on how the parent issue is resolved, these configs will likely require KSP 1.10 or later.

@Starstrider42 Starstrider42 added the enhancement New feature or request label Jul 5, 2020
@HSJasperism
Copy link
Contributor

HSJasperism commented Jul 10, 2020

Once Starstrider42/Custom-Asteroids#47 is implemented, create versions of the configs that use stock comets. Depending on how the parent issue is resolved, these configs will likely require KSP 1.10 or later.

I'll try to update these as soon as the main mod is compatible with with 1.10 comets (do you need anything particular for the main mod?)

Meanwhile, I can start getting statistics on distribution and prepare a good game-ified version for OPM.

@HSJasperism
Copy link
Contributor

Hey. Kopernicus is still locked to 1.8, with some unofficial 1.9 compiles making the rounds. If this is updated for 1.10, it still needs to wait for Kopernicus before testing can be done.

@Starstrider42
Copy link
Owner Author

Sorry, but Starstrider42/Custom-Asteroids#47 really is a blocker for this. The more comet-like aspects of 1.10 comets (including tails) aren't done by PartModules like they are for asteroids, so there will need to be some code changes before CA comets will work like players expect.

I assume the same holds for Kopernicus, so it may be a while before this issue is doable.

@Starstrider42
Copy link
Owner Author

Starstrider42 commented Jan 23, 2021

I've tested the new configs on KSP 1.11 with OPM 2.2.8 and Kopernicus R-T-B 61.

The biggest change is that, since for the stock game intermediate-period comets are now defined in Stockalike.cfg instead of Trans-Jool.cfg, Trans-Neidon.cfg rescales those instead of rolling its own. I don't think the soft dependency will be a problem in practice, but I plan to have CKAN recommend Stockalike to Trans-Neidon users just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants