New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(applyPatch): correct comment #322

Open

code-forger wants to merge 1 commit into Starcounter-Jack:master from code-forger:patch-1

code-forger commented Mar 6, 2024

Sorry for the super tiny PR.

However in this comment, its noted that passing down the input param mutateDocument is unnecessary.

This is because in the case mutateDocument was **true** passing down true is effectively a no-op.

and in the case mutateDocument was **false** a deep clone has already taken place, so further deep clones are redundant and affect performance.

The comment had the above switched.


          chore(applyPatch): correct comment

b7a3afb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet