Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] improve sql digest for massive compound predicates (backport #53207) #53341

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 28, 2024

Why I'm doing:

What I'm doing:

In cases where an OR predicate is dynamically constructed with a fixed column, the SQL digest varies due to a differing number of predicates. To address this, we consolidate extensive compound predicates into a compact format, ensuring consistent SQL digests.

where c_code like 'a%';
where c_code like 'a%' or c_code like 'b%';
where c_code like 'a%' or c_code like 'b%' or c_code like 'c%';

=> 

where $massive_compounds[c_code]$

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

Why I'm doing:

What I'm doing:

In cases where an OR predicate is dynamically constructed with a fixed column, the SQL digest varies due to a differing number of predicates. To address this, we consolidate extensive compound predicates into a compact format, ensuring consistent SQL digests.

where c_code like 'a%';
where c_code like 'a%' or c_code like 'b%';
where c_code like 'a%' or c_code like 'b%' or c_code like 'c%';

=> 

where $massive_compounds[c_code]$

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit c411ac5)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/analysis/Expr.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java
@mergify mergify bot added the conflicts label Nov 28, 2024
Copy link
Contributor Author

mergify bot commented Nov 28, 2024

Cherry-pick of c411ac5 has failed:

On branch mergify/bp/branch-3.3/pr-53207
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit c411ac513d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/analysis/SlotRef.java
	modified:   fe/fe-core/src/main/java/com/starrocks/planner/LoadScanNode.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/common/SqlDigestBuilder.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/common/SqlDigestBuilderTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/analysis/Expr.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 28, 2024 12:41
@mergify mergify bot closed this Nov 28, 2024
auto-merge was automatically disabled November 28, 2024 12:41

Pull request was closed

Copy link
Contributor Author

mergify bot commented Nov 28, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant