[Enhancement] Add pendingTime/netTime/netComputeTime to queryDetail #53322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
ZiheLiu
previously approved these changes
Nov 28, 2024
Signed-off-by: satanson <[email protected]>
satanson
force-pushed
the
add_netTime_netComputeTime
branch
from
c07938e
to
2fa431b
Compare
|
ZiheLiu
approved these changes
Nov 29, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 21 / 26 (80.77%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…53322) Signed-off-by: satanson <[email protected]> (cherry picked from commit 6c556d8)
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…53322) Signed-off-by: satanson <[email protected]> (cherry picked from commit 6c556d8)
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…53322) Signed-off-by: satanson <[email protected]> (cherry picked from commit 6c556d8) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/profile/Tracers.java # fe/fe-core/src/test/java/com/starrocks/qe/QueryDetailQueueTest.java
This was referenced Nov 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…53322) Signed-off-by: satanson <[email protected]> (cherry picked from commit 6c556d8) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/profile/TimeWatcher.java # fe/fe-core/src/main/java/com/starrocks/common/profile/Tracer.java # fe/fe-core/src/main/java/com/starrocks/common/profile/TracerImpl.java # fe/fe-core/src/main/java/com/starrocks/common/profile/Tracers.java # fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java # fe/fe-core/src/test/java/com/starrocks/qe/QueryDetailQueueTest.java
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
…53322) Signed-off-by: satanson <[email protected]> (cherry picked from commit 6c556d8) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/profile/TimeWatcher.java # fe/fe-core/src/main/java/com/starrocks/common/profile/Tracer.java # fe/fe-core/src/main/java/com/starrocks/common/profile/TracerImpl.java # fe/fe-core/src/main/java/com/starrocks/common/profile/Tracers.java # fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java # fe/fe-core/src/test/java/com/starrocks/qe/QueryDetailQueueTest.java
This was referenced Nov 29, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 30, 2024
…backport #53322) (#53378) Co-authored-by: satanson <[email protected]>
LiShuMing
pushed a commit
to LiShuMing/starrocks
that referenced
this pull request
Dec 2, 2024
…tarRocks#53322) Signed-off-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 2, 2024
…backport #53322) (#53377) Co-authored-by: satanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Add pendingTime, netTime, netComputeTime to QueryDetail, so we can sort history query list by netTime or netComputeTime in byoc-admin to find out real top-N slow queries.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: