-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] fix connector mem scan limit adjustment when no chunk source #53112
Open
dirtysalt
wants to merge
4
commits into
StarRocks:main
Choose a base branch
from
dirtysalt:fix-alloc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirtysalt
changed the title
[Enhancement] fix connector mem scan limit for no chunk source
[Enhancement] fix connector mem scan limit adjustment when no chunk source
Nov 22, 2024
zombee0
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Youngwb
previously approved these changes
Nov 22, 2024
Quality Gate failedFailed conditions |
[BE Incremental Coverage Report]❌ fail : 8 / 11 (72.73%) file detail
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 8 / 8 (100.00%) file detail
|
tracymacding
approved these changes
Nov 25, 2024
ZiheLiu
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
This is the further improvement on this PR: #50686
We find a bad case that
And this case can be reproduced by following SQL
select lo_orderkey from ICE
has dataSo the execution profile looks like this
And if you look at
PeakIOTasks
ofICE
table, it's very low probably like 3-4, which is bad.The root cause is, since we have this PR: #50686
However, there is a corner case that: if the scan operator does not create any chunk source, it has no chance to adjust it's chunk usage back to 0. And it affects other scan operator's available mem limit, which leads to low io tasks.
What I'm doing:
This PR is to:
do_preapre
anddo_close
. so it will do adjustment even there is no chunk source created.scan_node_number
to more proper nameconnector_scan_node_number
. So there won't be problems if there are no-connector scan node and connector scan nodes in a single query.Fixes #50686
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: