Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support dummy alter warehouse #53039

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

starrocks-xupeng
Copy link
Contributor

@starrocks-xupeng starrocks-xupeng commented Nov 20, 2024

Why I'm doing:

What I'm doing:

community behavior

mysql> alter warehouse default_warehouse set ('compute_replica'='2');
ERROR 1064 (HY000): Multi-Warehouse is not implemented

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

kevincai
kevincai previously approved these changes Nov 20, 2024
HangyuanLiu
HangyuanLiu previously approved these changes Nov 20, 2024
@starrocks-xupeng
Copy link
Contributor Author

@mergify rerun

Copy link
Contributor

mergify bot commented Nov 20, 2024

rerun

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 13 / 45 (28.89%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/ast/AstVisitor.java 0 1 00.00% [1029]
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 0 8 00.00% [2789, 2790, 2791, 2792, 2793, 2794, 2795, 2796]
🔵 com/starrocks/lake/StarOSAgent.java 0 8 00.00% [747, 756, 758, 759, 760, 761, 762, 763]
🔵 com/starrocks/qe/DDLStmtExecutor.java 1 5 20.00% [1181, 1183, 1184, 1185]
🔵 com/starrocks/sql/ast/warehouse/AlterWarehouseStmt.java 6 16 37.50% [30, 31, 46, 50, 51, 60, 61, 62, 63, 64]
🔵 com/starrocks/sql/analyzer/WarehouseAnalyzer.java 3 4 75.00% [103]
🔵 com/starrocks/server/WarehouseManager.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/Analyzer.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@andyziye andyziye merged commit c7ae18d into StarRocks:main Nov 21, 2024
52 of 53 checks passed
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants