Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Use STARROCKS_ROOT env #53029

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[BugFix] Use STARROCKS_ROOT env #53029

merged 2 commits into from
Nov 20, 2024

Conversation

yandongxiao
Copy link
Contributor

Why I'm doing:

Use STARROCKS_ROOT env instead on hard code /opt/starrocks

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@yandongxiao yandongxiao requested a review from a team as a code owner November 20, 2024 02:16
@github-actions github-actions bot added the 3.3 label Nov 20, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@nshangyiming nshangyiming merged commit a4385a2 into StarRocks:main Nov 20, 2024
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@yandongxiao @mergify
[BugFix] Use STARROCKS_ROOT env (#53029)
a0d3b70 
Signed-off-by: yandongxiao <[email protected]>
(cherry picked from commit a4385a2)
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 20, 2024
@mergify @yandongxiao
[BugFix] Use STARROCKS_ROOT env (backport #53029) (#53040)
d5ccd00 
Co-authored-by: yandongxiao <[email protected]>
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
@yandongxiao @Smith-Cruise
[BugFix] Use STARROCKS_ROOT env (StarRocks#53029)
ec27277 
Signed-off-by: yandongxiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@yandongxiao yandongxiao

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yandongxiao @kevincai @nshangyiming