Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix spill cost too much memory when enable group execution (backport #51935) #52094

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 18, 2024

Why I'm doing:

SSB100G

set pipeline_dop=1;
set enable_spill=true;
set spill_mode="force";
set enable_spill_buffer_read=false;
select count(*) from (select count(*) from lineorder group by lo_orderkey)t;

baseline:

     - QueryExecutionWallTime: 23s409ms
     - QueryPeakMemoryUsagePerNode: 1.182 GB
     - QueryPeakScheduleTime: 21.029ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 2.363 GB

fixed:

     - QueryExecutionWallTime: 22s812ms
     - QueryPeakMemoryUsagePerNode: 82.066 MB
     - QueryPeakScheduleTime: 21.634ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 164.131 MB

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51935 done by [Mergify](https://mergify.com). ## Why I'm doing: SSB100G ``` set pipeline_dop=1; set enable_spill=true; set spill_mode="force"; set enable_spill_buffer_read=false; select count(*) from (select count(*) from lineorder group by lo_orderkey)t; ```

baseline:

     - QueryExecutionWallTime: 23s409ms
     - QueryPeakMemoryUsagePerNode: 1.182 GB
     - QueryPeakScheduleTime: 21.029ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 2.363 GB

fixed:

     - QueryExecutionWallTime: 22s812ms
     - QueryPeakMemoryUsagePerNode: 82.066 MB
     - QueryPeakScheduleTime: 21.634ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 164.131 MB

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit e3f7023 into branch-3.3 Oct 19, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51935 branch October 19, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants