[BugFix] Unable to set storage_cooldown_time to maximum when creating MaterializedView. #52079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MaterializedView. Signed-off-by: edwinhzhang <[email protected]>
zhangheihei
force-pushed
the
bugxif-mv-cooldowntime
branch
from
2bf26ff
to
265e45c
Compare
|
LiShuMing
reviewed
Oct 18, 2024
| @@ -1456,8 +1455,7 @@ public static Map<String, String> getPartitionProperties(MaterializedView materi | |||
| partitionProperties.put("storage_medium", materializedView.getStorageMedium()); | |||
| String storageCooldownTime = | |||
| materializedView.getTableProperty().getProperties().get("storage_cooldown_time"); | |||
| if (storageCooldownTime != null | |||
| && !storageCooldownTime.equals(String.valueOf(DataProperty.MAX_COOLDOWN_TIME_MS))) { | |||
There was a problem hiding this comment.
MAX_COOLDOWN_TIME_MS(9999-12-31 23:59:59) is an invalid cool down time, why needs to update it?
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
LiShuMing
approved these changes
Oct 18, 2024
| @@ -1456,8 +1455,7 @@ public static Map<String, String> getPartitionProperties(MaterializedView materi | |||
| partitionProperties.put("storage_medium", materializedView.getStorageMedium()); | |||
| String storageCooldownTime = | |||
| materializedView.getTableProperty().getProperties().get("storage_cooldown_time"); | |||
| if (storageCooldownTime != null | |||
| && !storageCooldownTime.equals(String.valueOf(DataProperty.MAX_COOLDOWN_TIME_MS))) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
murphyatwork
approved these changes
Oct 18, 2024
Seaven
approved these changes
Oct 18, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
… MaterializedView. (#52079) Signed-off-by: edwinhzhang <[email protected]> (cherry picked from commit 01bf895) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java # fe/fe-core/src/test/java/com/starrocks/catalog/MaterializedViewTest.java
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
… MaterializedView. (#52079) Signed-off-by: edwinhzhang <[email protected]> (cherry picked from commit 01bf895)
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
… MaterializedView. (#52079) Signed-off-by: edwinhzhang <[email protected]> (cherry picked from commit 01bf895) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java # fe/fe-core/src/test/java/com/starrocks/catalog/MaterializedViewTest.java
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #52082
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: