Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor reset ids for restore #52075

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[Refactor] Refactor reset ids for restore #52075

merged 1 commit into from
Oct 18, 2024

Conversation

xiangguangyxg
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg xiangguangyxg requested review from a team as code owners October 18, 2024 04:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 100 / 106 (94.34%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/ListPartitionInfo.java 27 31 87.10% [678, 682, 690, 694]
🔵 com/starrocks/catalog/RangePartitionInfo.java 15 16 93.75% [593]
🔵 com/starrocks/catalog/PartitionInfo.java 29 30 96.67% [350]
🔵 com/starrocks/catalog/OlapTable.java 29 29 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit 9db7976 into StarRocks:main Oct 18, 2024
54 checks passed
@xiangguangyxg
Copy link
Contributor Author

@mergify backport branch-3.3 branch-3.2 branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.3 branch-3.2 branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@xiangguangyxg @mergify
[Refactor] Refactor reset ids for restore (#52075)
f2bdef1 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 9db7976)
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@xiangguangyxg @mergify
[Refactor] Refactor reset ids for restore (#52075)
a54a736 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 9db7976)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/ListPartitionInfo.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@xiangguangyxg @mergify
[Refactor] Refactor reset ids for restore (#52075)
7d7c2c5 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 9db7976)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/ListPartitionInfo.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
This was referenced Oct 18, 2024
Merged
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Refactor] Refactor reset ids for restore (backport #52075) (#52086)
8c85bc3 
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Refactor] Refactor reset ids for restore (backport #52075) (#52087)
5f21c63 
Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @xiangguangyxg
[Refactor] Refactor reset ids for restore (backport #52075) (#52088)
8e1e2f8 
Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg deleted the refactor_reset_ids branch October 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiangguangyxg @kevincai @wyb @gengjun-git