[Enhancement] Loading task should abort transaction if fail because of timeout (backport #51939) #52010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…f timeout (#51939) Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit 73172c3)
24 tasks
|
wyb
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In #38183, broker load will retry if loading task fails because of timeout. But currently the retry will be executed until transaction timeouts even if the loading task has failed before transaction timeout. For example, the task fails because BE BRPC timeouts which is half of transaction timeout by default, and the load should retry immediately after the task fails.
What I'm doing:
If the task fails because of timeout, abort the transaction so that it can try as soon as possible
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #51939 done by [Mergify](https://mergify.com). ## Why I'm doing: In #38183, broker load will retry if loading task fails because of timeout. But currently the retry will be executed until transaction timeouts even if the loading task has failed before transaction timeout. For example, the task fails because BE BRPC timeouts which is half of transaction timeout by default, and the load should retry immediately after the task fails.
What I'm doing:
If the task fails because of timeout, abort the transaction so that it can try as soon as possible
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: