Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] show create table displays Unicode encoding for default value of the field is entered in Chinese characters #51997

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rohitrs1983
Copy link
Contributor

@rohitrs1983 rohitrs1983 commented Oct 16, 2024

show create table displays Unicode encoding for default value of the field is entered in Chinese characters

Why I'm doing:

What I'm doing:

Fixes #51995

mysql> show create table test111111;
+------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table |
+------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| test111111 | CREATE TABLE test111111 (
test3 varchar(111) NULL DEFAULT "撒" COMMENT "撒",
test1 char(10) NULL DEFAULT "撒" COMMENT "撒",
test2 varchar(1) NULL DEFAULT "撒" COMMENT "撒",
test4 char(1) NULL DEFAULT "撒" COMMENT "撒",
test5 tinyint(4) NULL COMMENT "test1",
test6 varchar(1) NULL COMMENT "test2"
) ENGINE=OLAP
DUPLICATE KEY(test3)
DISTRIBUTED BY HASH(test3)
PROPERTIES (
"compression" = "LZ4",
"fast_schema_evolution" = "true",
"replicated_storage" = "true",
"replication_num" = "1"
); |
+------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

…e of the field is entered in Chinese characters

Signed-off-by: Rohit Satardekar <[email protected]>
@rohitrs1983 rohitrs1983 requested a review from a team as a code owner October 16, 2024 13:25
…e of the field is entered in Chinese characters

Signed-off-by: Rohit Satardekar <[email protected]>
…e of the field is entered in Chinese characters

Signed-off-by: Rohit Satardekar <[email protected]>
@rohitrs1983
Copy link
Contributor Author

@kevincai added UT validation. please review.

Copy link

sonarcloud bot commented Oct 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Column.java 4 4 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

字段 default 值输入汉字,show create table 显示的是 Unicode编码,
2 participants