Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Implement Subfield visitor in ScalarOperatorsReuse #51991

Closed
wants to merge 1 commit into from

Conversation

Jcnessss
Copy link

Why I'm doing:

For now, ScalarOperatorsReuse has a lack of a implement of Subfield visitor. So for the sql below, the common expr will be computed multiple times:
select
(
case
when "hero_row.hero_level" < 0 then '10000->-∞0'
when "hero_row.hero_level" >= 0
and "hero_row.hero_level" < 10 then '10001->0
10'
when "hero_row.hero_level" >= 10
and "hero_row.hero_level" < 20 then '10002->10~20'
else NULL
end
) group_3
from
(
select
CAST(parse_json(hero_row) as row(hero_equipment array, hero_if_support varchar, begin_time datetime, hero_level double, hero_name varchar))."hero_level" "hero_row.hero_level"
from
kudu.t.user_3
)

What I'm doing:

Implement ScalarOperatorRewriter#visitSubfield to make the common operator mechanism works well.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Jcnessss Jcnessss requested a review from a team as a code owner October 16, 2024 10:13
@Jcnessss Jcnessss closed this Oct 16, 2024
@Jcnessss Jcnessss deleted the reuse branch October 16, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant