Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix .net can not read sr (backport #51946) #51958

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Why I'm doing:

fix #44024
.net's mysql connector "MySQL.Data" will select @@autocommit to do some check when establish connection, but it assume select @@autocommit will return a Integer(Mysql return BigInt). But we return Boolean, which cause "MySQL.Data" thorw exception when establish connection.

What I'm doing:

change "select @@autocommit" 's return type from boolean to BigInt, which is same as Mysql's behavior. Test with jdbc and .net's mysql connector "MySQL.Data" , all work fine

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51946 done by [Mergify](https://mergify.com). ## Why I'm doing: fix https://github.com//issues/44024 .net's mysql connector "MySQL.Data" will select @@autocommit to do some check when establish connection, but it assume select @@autocommit will return a Integer(Mysql return BigInt). But we return Boolean, which cause "MySQL.Data" thorw exception when establish connection.

What I'm doing:

change "select @@autocommit" 's return type from boolean to BigInt, which is same as Mysql's behavior. Test with jdbc and .net's mysql connector "MySQL.Data" , all work fine

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit dbd40cd)
Copy link

sonarcloud bot commented Oct 16, 2024

@wanpengfei-git wanpengfei-git merged commit ca0d006 into branch-3.3 Oct 17, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51946 branch October 17, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants