Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix .net can not read sr (backport #51946) #51956

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Why I'm doing:

fix #44024
.net's mysql connector "MySQL.Data" will select @@autocommit to do some check when establish connection, but it assume select @@autocommit will return a Integer(Mysql return BigInt). But we return Boolean, which cause "MySQL.Data" thorw exception when establish connection.

What I'm doing:

change "select @@autocommit" 's return type from boolean to BigInt, which is same as Mysql's behavior. Test with jdbc and .net's mysql connector "MySQL.Data" , all work fine

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51946 done by [Mergify](https://mergify.com). ## Why I'm doing: fix https://github.com//issues/44024 .net's mysql connector "MySQL.Data" will select @@autocommit to do some check when establish connection, but it assume select @@autocommit will return a Integer(Mysql return BigInt). But we return Boolean, which cause "MySQL.Data" thorw exception when establish connection.

What I'm doing:

change "select @@autocommit" 's return type from boolean to BigInt, which is same as Mysql's behavior. Test with jdbc and .net's mysql connector "MySQL.Data" , all work fine

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit dbd40cd)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/qe/VariableMgrTest.java
@mergify mergify bot added the conflicts label Oct 16, 2024
Copy link
Contributor Author

mergify bot commented Oct 16, 2024

Cherry-pick of dbd40cd has failed:

On branch mergify/bp/branch-3.2/pr-51946
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit dbd40cd4aa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/ExpressionAnalyzer.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/qe/VariableMgrTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Oct 16, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Oct 16, 2024
auto-merge was automatically disabled October 16, 2024 05:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant