[BugFix] Fix incorrect materialized view row count #51944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaijianding
force-pushed
the
mv_rowcount
branch
from
6fa0683
to
05e5e03
Compare
Signed-off-by: kaijian.ding <[email protected]>
kaijianding
force-pushed
the
mv_rowcount
branch
from
05e5e03
to
fc6866a
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
LiShuMing
approved these changes
Oct 17, 2024
murphyatwork
approved these changes
Oct 17, 2024
HangyuanLiu
approved these changes
Oct 17, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: kaijian.ding <[email protected]> (cherry picked from commit 1df36e4) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/TabletStatMgr.java
32 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: kaijian.ding <[email protected]> (cherry picked from commit 1df36e4) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/TabletStatMgr.java
32 tasks
dirtysalt
pushed a commit
to dirtysalt/starrocks
that referenced
this pull request
Oct 18, 2024
Signed-off-by: kaijian.ding <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 19, 2024
…52018) Signed-off-by: shuming.li <[email protected]> Co-authored-by: kaijianding <[email protected]> Co-authored-by: shuming.li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix incorrect mv row count which introduced in #50668
What I'm doing:
The
MaterializedIndexobject is different in everyphysicalPartition, but with the sameindex.getId(), so theindexRowCountMap.put(index.getId(), indexRowCount)will overwrite previous mv partition's row count with the later partition's row countFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
Checklist:
Bugfix cherry-pick branch check: