Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix BE crash when schema scan rpc failed (backport #51889) #51910

Closed
wants to merge 1 commit into from
Closed

[BugFix] Fix BE crash when schema scan rpc failed (backport #51889) #51910

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

in #49318 add a start interface for chunksource. but not check return status.

What I'm doing:

*** Aborted at 1728909404 (unix time) try "date -d @1728909404" if you are using GNU date ***
PC: @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
*** SIGSEGV (@0x28) received by PID 1854307 (TID 0x7f0b1bbff640) from PID 40; stack trace: ***
    @     0x7f0cb7d89ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0x8f2bb29 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f0cb7d32520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
    @          0x6bbdf4c starrocks::SchemaVariablesScanner::get_next(std::shared_ptr<starrocks::Chunk>*, bool*)
    @          0x6bb8d39 starrocks::pipeline::SchemaChunkSource::_read_chunk(starrocks::RuntimeState*, std::shared_ptr<starrocks::Chunk>*)
    @          0x4dd429f starrocks::pipeline::ChunkSource::buffer_next_batch_chunks_blocking(starrocks::RuntimeState*, unsigned long, starrocks::workgroup::WorkGroup const*)
    @          0x4d1967f auto starrocks::pipeline::ScanOperator::_trigger_next_scan(starrocks::RuntimeState*, int)::{lambda(auto:1&)#1}::operator()<starrocks::workgroup::YieldContext>(starrocks::workgroup::YieldContext&) const [clone .constprop.0]
    @          0x4663b9e starrocks::workgroup::ScanExecutor::worker_thread()
    @          0x7bb93b2 starrocks::ThreadPool::dispatch_thread()
    @          0x7bb16a9 starrocks::Thread::supervise_thread(void*)
    @     0x7f0cb7d84ac3 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
    @     0x7f0cb7e16850 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x12684f)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #51889 done by [Mergify](https://mergify.com). ## Why I'm doing:

in #49318 add a start interface for chunksource. but not check return status.

What I'm doing:

*** Aborted at 1728909404 (unix time) try "date -d @1728909404" if you are using GNU date ***
PC: @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
*** SIGSEGV (@0x28) received by PID 1854307 (TID 0x7f0b1bbff640) from PID 40; stack trace: ***
    @     0x7f0cb7d89ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0x8f2bb29 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f0cb7d32520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
    @          0x6bbdf4c starrocks::SchemaVariablesScanner::get_next(std::shared_ptr<starrocks::Chunk>*, bool*)
    @          0x6bb8d39 starrocks::pipeline::SchemaChunkSource::_read_chunk(starrocks::RuntimeState*, std::shared_ptr<starrocks::Chunk>*)
    @          0x4dd429f starrocks::pipeline::ChunkSource::buffer_next_batch_chunks_blocking(starrocks::RuntimeState*, unsigned long, starrocks::workgroup::WorkGroup const*)
    @          0x4d1967f auto starrocks::pipeline::ScanOperator::_trigger_next_scan(starrocks::RuntimeState*, int)::{lambda(auto:1&)#1}::operator()<starrocks::workgroup::YieldContext>(starrocks::workgroup::YieldContext&) const [clone .constprop.0]
    @          0x4663b9e starrocks::workgroup::ScanExecutor::worker_thread()
    @          0x7bb93b2 starrocks::ThreadPool::dispatch_thread()
    @          0x7bb16a9 starrocks::Thread::supervise_thread(void*)
    @     0x7f0cb7d84ac3 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
    @     0x7f0cb7e16850 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x12684f)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@stdpain @mergify
[BugFix] Fix BE crash when schema scan rpc failed (#51889)
2d4c84e 
## Why I'm doing:

in #49318 add a start interface for chunksource. but not check return status.

## What I'm doing:

```
*** Aborted at 1728909404 (unix time) try "date -d @1728909404" if you are using GNU date ***
PC: @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
*** SIGSEGV (@0x28) received by PID 1854307 (TID 0x7f0b1bbff640) from PID 40; stack trace: ***
    @     0x7f0cb7d89ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0x8f2bb29 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f0cb7d32520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @          0x6bbdd8b starrocks::SchemaVariablesScanner::fill_chunk(std::shared_ptr<starrocks::Chunk>*)
    @          0x6bbdf4c starrocks::SchemaVariablesScanner::get_next(std::shared_ptr<starrocks::Chunk>*, bool*)
    @          0x6bb8d39 starrocks::pipeline::SchemaChunkSource::_read_chunk(starrocks::RuntimeState*, std::shared_ptr<starrocks::Chunk>*)
    @          0x4dd429f starrocks::pipeline::ChunkSource::buffer_next_batch_chunks_blocking(starrocks::RuntimeState*, unsigned long, starrocks::workgroup::WorkGroup const*)
    @          0x4d1967f auto starrocks::pipeline::ScanOperator::_trigger_next_scan(starrocks::RuntimeState*, int)::{lambda(auto:1&)#1}::operator()<starrocks::workgroup::YieldContext>(starrocks::workgroup::YieldContext&) const [clone .constprop.0]
    @          0x4663b9e starrocks::workgroup::ScanExecutor::worker_thread()
    @          0x7bb93b2 starrocks::ThreadPool::dispatch_thread()
    @          0x7bb16a9 starrocks::Thread::supervise_thread(void*)
    @     0x7f0cb7d84ac3 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
    @     0x7f0cb7e16850 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x12684f)
```

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit b2a4c8a)

# Conflicts:
#	be/src/exec/pipeline/scan/scan_operator.cpp
#	be/src/exec/schema_scanner/schema_variables_scanner.cpp
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 15, 2024

Cherry-pick of b2a4c8a has failed:

On branch mergify/bp/branch-3.1/pr-51889
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit b2a4c8aa84.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/sql/test_scan/R/test_schema_scan_rpc_failed
	new file:   test/sql/test_scan/T/test_schema_scan_rpc_failed

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/pipeline/scan/scan_operator.cpp
	both modified:   be/src/exec/schema_scanner/schema_variables_scanner.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 15, 2024
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 15, 2024 04:14
@mergify mergify bot closed this Oct 15, 2024
auto-merge was automatically disabled October 15, 2024 04:14

Pull request was closed

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 15, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stdpain stdpain

Labels
automerge conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stdpain