Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix setDouble issue in jdbc with prepare stmt (backport #51811) #51900

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 15, 2024

Why I'm doing:

fix setDouble issue in jdbc with prepare stmt:
image

the result is wrong:
image

the reason is wrong type processing in FloatLiteral::parseMysqlParam.
For example, the data is of double type, but the getFloat method is used to obtain the data, result in wrong value.

What I'm doing:

When a new floatLiteral object is created, its type should be specified explicitly, not based on its numeric size.
Otherwise, when the data is small, it will be processed as the float type, even if the value is assigned by setDouble method in JDBC.

image

ths result is right:
image

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51811 done by [Mergify](https://mergify.com). ## Why I'm doing: fix setDouble issue in jdbc with prepare stmt: ![image](https://github.com/user-attachments/assets/2fd49aac-4353-4e03-a8fe-3a43a4b990ab)

the result is wrong:
image

the reason is wrong type processing in FloatLiteral::parseMysqlParam.
For example, the data is of double type, but the getFloat method is used to obtain the data, result in wrong value.

What I'm doing:

When a new floatLiteral object is created, its type should be specified explicitly, not based on its numeric size.
Otherwise, when the data is small, it will be processed as the float type, even if the value is assigned by setDouble method in JDBC.

image

ths result is right:
image

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit 9545359 into branch-3.3 Oct 19, 2024
33 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-51811 branch October 19, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants