Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Fix the clang-tidy check #50950

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 11, 2024

Why I'm doing:

What I'm doing:

[ 62%] Building CXX object src/runtime/CMakeFiles/Runtime.dir/runtime_state.cpp.o
/root/starrocks/be/src/storage/lake/pk_tablet_writer.h:59:47: error: private field '_column_to_expr_value' is not used [clang-diagnostic-unused-private-field]
    const std::map<std::string, std::string>* _column_to_expr_value = nullptr;
                                              ^
8444 warnings and 1 error generated.
Error while processing /root/starrocks/be/src/storage/lake/pk_tablet_writer.cpp.
Suppressed 8447 warnings (8440 in non-user code, 3 NOLINT, 4 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu trueeyu requested a review from a team as a code owner September 11, 2024 01:49
@kevincai kevincai requested a review from sevev September 11, 2024 01:54
@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 18, 2024

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Sep 18, 2024

rebase main

✅ Branch has been successfully rebased

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@trueeyu trueeyu merged commit cdb1c2b into StarRocks:main Sep 18, 2024
41 checks passed
@kevincai
Copy link
Contributor

@mergify backport branch-3.3

Copy link
Contributor

mergify bot commented Oct 17, 2024

backport branch-3.3

✅ Backports have been created

@kevincai
Copy link
Contributor

has the same issue on branch-3.3, backport to branch-3.3

mergify bot pushed a commit that referenced this pull request Oct 17, 2024
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit cdb1c2b)
wanpengfei-git pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants