[BugFix] Avoid hdfs fs manager interrupting the thread when exception occurs (backport #48403) #48695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… occurs (#48403) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 3fcafac)
24 tasks
|
kevincai
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When exception occurs in hdfs fs manager, the current thread will be interrupted, causing
InterruptedExceptionorClosedByInterruptExceptionin subsequent code execution.This may cause the following problem:
User backup data to a HDFS repository, and then releases the HDFS cluster. When FE starts, it will access the released HDFS cluster. If the access fails, the current thread will be interrupted, an
InterruptedIOExceptionorClosedByInterruptExceptionis thrown and the startup fails.What I'm doing:
Avoid hdfs fs manager interrupting the thread by clearing the interrupted flag when exception occurs.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48403 done by [Mergify](https://mergify.com). ## Why I'm doing: When exception occurs in hdfs fs manager, the current thread will be interrupted, causing `InterruptedException` or `ClosedByInterruptException` in subsequent code execution.
This may cause the following problem:
User backup data to a HDFS repository, and then releases the HDFS cluster. When FE starts, it will access the released HDFS cluster. If the access fails, the current thread will be interrupted, an
InterruptedIOExceptionorClosedByInterruptExceptionis thrown and the startup fails.What I'm doing:
Avoid hdfs fs manager interrupting the thread by clearing the interrupted flag when exception occurs.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: