Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] upgrade thirdparty brpc & glog #48233

Closed
wants to merge 6 commits into from
Closed

[Enhancement] upgrade thirdparty brpc & glog #48233

wants to merge 6 commits into from

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jul 11, 2024 •
edited
Loading

Why I'm doing:

upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in https://github.com/google/glog/pull/650  
we could make our verbose log powerful

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain requested a review from a team as a code owner July 11, 2024 14:13
@alvin-celerdata
Copy link
Contributor

@stdpain how about upgrading the BRPC version first?

@stdpain stdpain requested a review from a team as a code owner July 12, 2024 02:46
@stdpain stdpain changed the title [Enhancement] introduce brpc thrift extends [Enhancement] upgrade brpc and introduce brpc thrift extends Jul 12, 2024
@stdpain
Copy link
Contributor Author

stdpain commented Jul 12, 2024

@alvin-celerdata upgrade to 1.9.0

@alvin-celerdata
Copy link
Contributor

@stdpain how about upgrading the BRPC version first?

Can you update the name of this PR?

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

kevincai
kevincai reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@kevincai kevincai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't upgrade brpc directly in starrocks. need upgrade brpc version in starcache and in starlet first. otherwise these modules will be broken.

@stdpain stdpain changed the title [Enhancement] upgrade brpc and introduce brpc thrift extends [Enhancement] upgrade brpc & glog Jul 12, 2024
@stdpain
Copy link
Contributor Author

stdpain commented Jul 12, 2024

@kevincai how can i upgrade starlet & starcache?

@stdpain stdpain force-pushed the introduce_brpc_thrift branch 2 times, most recently from 00df55f to bff316c Compare July 12, 2024 08:35
@stdpain stdpain changed the title [Enhancement] upgrade brpc & glog [Enhancement] upgrade thirdparty brpc & glog Jul 12, 2024
@stdpain stdpain force-pushed the introduce_brpc_thrift branch 3 times, most recently from 7c468c9 to 998f03e Compare July 12, 2024 11:20
@stdpain
[Enhancement] upgrade some thirdparty
28c274f 
upgrade brpc to 1.9.0
upgrade glog to 0.7.1

brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md
we could use brpc async interface instead of using thread pool simulate an async interface

glog has support change vlog level dynamic in google/glog#650

Signed-off-by: stdpain <[email protected]>
@kevincai
Copy link
Contributor

@kevincai how can i upgrade starlet & starcache?

can ask @GavinMar help to upgrade the thirdparty version in starcache and then I can help with the upgrade in starlet.

@stdpain stdpain requested a review from a team as a code owner July 15, 2024 03:00
@stdpain stdpain force-pushed the introduce_brpc_thrift branch 3 times, most recently from 438c76f to 13a6a26 Compare July 16, 2024 12:08
@stdpain
fix glog inner api
0478a3e 
Signed-off-by: stdpain <[email protected]>
@stdpain stdpain mentioned this pull request Jul 18, 2024
Merged
24 tasks
@stdpain
fix include
925e75f 
Signed-off-by: stdpain <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kevincai kevincai mentioned this pull request Jul 29, 2024
Merged
24 tasks
@kevincai
Copy link
Contributor

deprecated by #48949

@stdpain
Copy link
Contributor Author

stdpain commented Jul 29, 2024

closed by #48949

@stdpain stdpain closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai left review comments

@trueeyu trueeyu trueeyu approved these changes

Assignees

@stdpain stdpain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stdpain @alvin-celerdata @kevincai @trueeyu