Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] making this version comparison more resilient as it fails issues/41016 (backport #42198) #42220

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2024

This is an automatic backport of pull request #42198 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Why I'm doing: Fixed https://github.com/StarRocks/dbt-starrocks/issues/23 which causes problems with version 3.2 Used to spit out `'>' not supported between instances of 'int' and 'str'`

What I'm doing:

Fixes #issue
StarRocks/dbt-starrocks#23

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…sues/41016 (#42198)

Fixed #41016 which causes problems with version 3.2
Used to spit out
'>' not supported between instances of 'int' and 'str'
Signed-off-by: Fardin Sarker <[email protected]>
(cherry picked from commit 81219ae)
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 6, 2024 10:47
@Astralidea Astralidea closed this Mar 6, 2024
auto-merge was automatically disabled March 6, 2024 10:55

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-42198 branch March 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants