Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Issue 39849]add datadog java/cpp profiling lib #40652

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

mingmxu
Copy link
Contributor

@mingmxu mingmxu commented Feb 2, 2024

Why I'm doing:
Add datadog java/cpp profling library to SR images, they're used in #39913.

What I'm doing:

^ add in artifacts image

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.1-cs
    • 3.0
    • 2.5

--- test plan----
The arm64/amd64 ddprof libraries:

wget "https://github.com/DataDog/ddprof/releases/download/v0.15.3/ddprof-0.15.3-arm64-linux.tar.xz" -O ddprof-linux.tar.xz \
    && tar xvf ddprof-linux.tar.xz && ls -l ddprof/bin/ddprof
> -rwxr-xr-x@ 1 m.xu  staff  20634896 Jan 22 06:58 ddprof/bin/ddprof


wget "https://github.com/DataDog/ddprof/releases/download/v0.15.3/ddprof-0.15.3-amd64-linux.tar.xz" -O ddprof-linux.tar.xz \
    && tar xvf ddprof-linux.tar.xz && ls -l ddprof/bin/ddprof
> -rwxr-xr-x@ 1 m.xu  staff  20813440 Jan 22 06:57 ddprof/bin/ddprof

Build multi-arc images, and check the ddprof file

# arm64
 DOCKER_BUILDKIT=1 docker buildx build --platform linux/arm64    -f docker/dockerfiles/artifacts/artifact.Dockerfile .
 

# amd64 
DOCKER_BUILDKIT=1 docker buildx build --platform linux/amd64    -f docker/dockerfiles/artifacts/artifact.Dockerfile .
 => => writing image sha256:d58cd0e655c62235c03d19a1ddefecf757393a69f3ab27bf7b339e4990e31d8c    

/release # ls -l be_artifacts/be/datadog/ddprof 
-rwxr-xr-x    1 root     root      20813440 Jan 22 14:57 be_artifacts/be/datadog/ddprof

# without `--platform` in CLI
DOCKER_BUILDKIT=1 docker buildx build    -f docker/dockerfiles/artifacts/artifact.Dockerfile .
=> => writing image sha256:d58cd0e655c62235c03d19a1ddefecf757393a69f3ab27bf7b339e4990e31d8c 

@mingmxu mingmxu requested a review from a team as a code owner February 2, 2024 21:31
@mergify mergify bot assigned mingmxu Feb 2, 2024
@mingmxu
Copy link
Contributor Author

mingmxu commented Feb 2, 2024

cc @kevincai @yandongxiao

kevincai
kevincai previously approved these changes Feb 4, 2024
@mingmxu mingmxu force-pushed the issue-39849/add_dd_libs branch 2 times, most recently from 7f54d5b to 550aa5a Compare February 4, 2024 21:52
remove unused TARGETARCH

Signed-off-by: Mingmin Xu <[email protected]>
Copy link

github-actions bot commented Feb 4, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kevincai kevincai enabled auto-merge (squash) February 4, 2024 23:51
@kevincai kevincai merged commit 1c280e0 into StarRocks:main Feb 5, 2024
51 checks passed
@kevincai
Copy link
Contributor

kevincai commented Feb 5, 2024

@Mergifyio backport branch-3.1 branch-3.2

Copy link
Contributor

mergify bot commented Feb 5, 2024

backport branch-3.1 branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 5, 2024
mergify bot pushed a commit that referenced this pull request Feb 5, 2024
mingmxu added a commit to mingmxu/starrocks that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants