Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix order by nan column overflow (#30759) #37024

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[BugFix] Fix order by nan column overflow (#30759) #37024

merged 1 commit into from
Dec 15, 2023

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Dec 14, 2023

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 15 / 18 (83.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/sorting/sort_helper.h 15 18 83.33% [89, 95, 96]

@wanpengfei-git wanpengfei-git merged commit ec2e1cd into StarRocks:branch-3.1 Dec 15, 2023
22 of 23 checks passed
@stdpain
Copy link
Contributor Author

stdpain commented Oct 12, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 12, 2024
@stdpain @mergify
[BugFix] Fix order by nan column overflow (#30759) (#37024)
91d9d18 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit ec2e1cd)
@mergify mergify bot mentioned this pull request Oct 12, 2024
Merged
kangkaisen pushed a commit that referenced this pull request Oct 16, 2024
@mergify @stdpain
[BugFix] Fix order by nan column overflow (#30759) (backport #37024) (#…
afb81bf 
…51846)

Co-authored-by: stdpain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

Assignees

@stdpain stdpain

Labels
3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdpain @trueeyu @wanpengfei-git