Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix spill cost too much memory when enable group execution #51935

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[BugFix] Fix spill cost too much memory when enable group execution #51935

merged 1 commit into from
Oct 18, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Oct 15, 2024 •
edited
Loading

Why I'm doing:

SSB100G

set pipeline_dop=1;
set enable_spill=true;
set spill_mode="force";
set enable_spill_buffer_read=false;
select count(*) from (select count(*) from lineorder group by lo_orderkey)t;

baseline:

     - QueryExecutionWallTime: 23s409ms
     - QueryPeakMemoryUsagePerNode: 1.182 GB
     - QueryPeakScheduleTime: 21.029ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 2.363 GB

fixed:

     - QueryExecutionWallTime: 22s812ms
     - QueryPeakMemoryUsagePerNode: 82.066 MB
     - QueryPeakScheduleTime: 21.634ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 164.131 MB

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain
[BugFix] Fix spill cost too much memory when enable group execution
fc4da58 
SSB100G
```
set pipeline_dop=1;
set enable_spill=true;
set spill_mode="force";
set enable_spill_buffer_read=false;
select count(*) from (select count(*) from lineorder group by lo_orderkey)t;
```

baseline:
```
     - QueryExecutionWallTime: 23s409ms
     - QueryPeakMemoryUsagePerNode: 1.182 GB
     - QueryPeakScheduleTime: 21.029ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 2.363 GB
```
fixed:
```
     - QueryExecutionWallTime: 22s812ms
     - QueryPeakMemoryUsagePerNode: 82.066 MB
     - QueryPeakScheduleTime: 21.634ms
     - QuerySpillBytes: 1.124 GB
     - QuerySumMemoryUsage: 164.131 MB
```

Signed-off-by: stdpain <[email protected]>
@stdpain stdpain requested a review from a team as a code owner October 15, 2024 08:34
@github-actions github-actions bot added the 3.3 label Oct 15, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/spill/mem_table.cpp 2 2 100.00% []

@stdpain stdpain merged commit 11ac7fb into StarRocks:main Oct 18, 2024
60 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 18, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Oct 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@stdpain @mergify
[BugFix] Fix spill cost too much memory when enable group execution (#…
2c45345 
…51935)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 11ac7fb)

# Conflicts:
#	be/src/exec/spill/mem_table.cpp
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@stdpain @mergify
[BugFix] Fix spill cost too much memory when enable group execution (#…
8f34f10 
…51935)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 11ac7fb)
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@stdpain @mergify
[BugFix] Fix spill cost too much memory when enable group execution (#…
53be6f9 
…51935)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 11ac7fb)

# Conflicts:
#	be/src/exec/spill/mem_table.cpp
This was referenced Oct 18, 2024
Merged
Closed
@mergify mergify bot mentioned this pull request Oct 18, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@stdpain @mergify
[BugFix] Fix spill cost too much memory when enable group execution (#…
0876aca 
…51935)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 11ac7fb)

# Conflicts:
#	be/src/exec/spill/mem_table.cpp
@mergify mergify bot mentioned this pull request Oct 18, 2024
Closed
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 19, 2024
@mergify @stdpain
[BugFix] Fix spill cost too much memory when enable group execution (…
e3f7023 
…backport #51935) (#52094)

Co-authored-by: stdpain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@stdpain stdpain

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdpain @silverbullet233 @Seaven