[BugFix] Fix thrift not call when retry times = 0 (#52067)

Signed-off-by: stdpain <[email protected]>
StarRocks · Oct 18, 2024 · a601695 · a601695
1 parent c46e2b9
commit a601695
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/be/src/util/thrift_rpc_helper.cpp b/be/src/util/thrift_rpc_helper.cpp
@@ -103,12 +103,14 @@ Status ThriftRpcHelper::rpc(const std::string& ip, const int32_t port,
  Status status;
  ClientConnection<T> client(_s_exec_env->get_client_cache<T>(), address, timeout_ms, &status);
  if (!status.ok()) {
+ _s_exec_env->get_client_cache<T>()->close_connections(address);
  LOG(WARNING) << "Connect " << ThriftMsgTypeTraits<T>::rpc_name << " failed, address=" << address
  << ", status=" << status.message();
  return status;
  }
 
- for (int i = 0; i < retry_times; i++) {
+ int i = 0;
+ do {
  status = rpc_impl(callback, client, address);
  if (status.ok()) {
  return Status::OK();
@@ -121,7 +123,7 @@ Status ThriftRpcHelper::rpc(const std::string& ip, const int32_t port,
  LOG(WARNING) << "client reopen failed. address=" << address << ", status=" << st.message();
  break;
  }
- }
+ } while (i++ < retry_times);
  return status;
 }