[BugFix] Prevent crash if type mismatch in BinaryDictPageDecoder (#52036

) Signed-off-by: Binglin Chang <[email protected]> (cherry picked from commit 5f10c07)
StarRocks · Oct 17, 2024 · 7963dd5 · 7963dd5
1 parent 3d50e33
commit 7963dd5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/be/src/storage/rowset/binary_dict_page.cpp b/be/src/storage/rowset/binary_dict_page.cpp
@@ -261,7 +261,9 @@ Status BinaryDictPageDecoder<Type>::next_batch(const SparseRange& range, Column*
  }
  }
 
- CHECK(dst->append_strings_overflow(slices, _max_value_legth));
+ bool ok = dst->append_strings_overflow(slices, _max_value_legth);
+ DCHECK(ok) << "append_strings_overflow failed";
+ RETURN_IF(!ok, Status::InternalError("BinaryDictPageDecoder::next_batch failed"));
  return Status::OK();
 }